Skip to content

Conversation

@stanlp1
Copy link
Contributor

@stanlp1 stanlp1 commented May 2, 2024

Pull Request Checklist

Before you submit a pull request, please make sure you have to following:

  • I have added or updated TypeScript types for my changes, ensuring they are compatible with the existing codebase.
  • I have added JSDoc comments to my TypeScript definitions for improved documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added any necessary documentation (if appropriate).
  • I have made sure my PR is up-to-date with the main branch.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Documentation content changes
  • TypeScript type definitions update
  • Other... Please describe:

@stanlp1 stanlp1 requested a review from a team May 2, 2024 00:17
@linear
Copy link

linear bot commented May 2, 2024

CI-3445 [MVP] PLP OS UI: Fix Encoding Issue

Business Outcome:

  • As a User of this Library I want good default url encoders so that I don't need to code

Definition of done:

  • Fix a bug where setRequestConfigs always identifies the page as browse page and continuously just appends /group_id/filterValue

Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me Don't Understand

giphy

@stanlp1
Copy link
Contributor Author

stanlp1 commented May 3, 2024

Me Don't Understand

giphy giphy

Talk about it in a huddle sometime today or next week?

Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stanlp1 stanlp1 merged commit b339cee into main May 8, 2024
@stanlp1 stanlp1 deleted the ci-3445-mvp-plp-os-ui-fix-encoding-issue branch May 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants