Skip to content

[CI-3445] MVP - stop mutating path #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

[CI-3445] MVP - stop mutating path #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions spec/urlHelpers.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,6 @@ describe('Testing Default UrlHelpers: getUrlFromState', () => {
expect(params.has(testRequestState.filterName)).toBe(false);
expect(params.has(testRequestState.filterValue)).toBe(false);
});

test('Should encode filterName and filterValue as part of the path', () => {
const urlString = getUrlFromState(testRequestState as RequestConfigs, {
baseUrl: 'https://www.example.com/a/random/path',
});
const url = new URL(urlString);
const paths = url.pathname.split('/');

expect(paths.indexOf(testRequestState.filterName)).not.toBe(-1);
expect(paths.indexOf(testRequestState.filterValue)).not.toBe(-1);
});
});

describe('Testing Default UrlHelpers: getStateFromUrl', () => {
Expand Down
2 changes: 1 addition & 1 deletion spec/useBrowseResults.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('Testing Hook: useBrowseResults', () => {

const url = getUrlFromState(
{ filterValue: '123', filters, resultsPerPage, page },
{ baseUrl: 'https://example.com/browse/' },
{ baseUrl: 'https://example.com/browse/123' },
);
mockLocation.href = url;

Expand Down
7 changes: 1 addition & 6 deletions src/utils/urlHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,5 @@ export function getUrlFromState(
}
});

let groupPath = '';
if (state.filterValue) {
groupPath = `/${state.filterName}/${state.filterValue}`;
}

return `${baseUrl}${groupPath}?${params.toString()}`;
return `${baseUrl}?${params.toString()}`;
}