[CI-3445] Stop changing url path (#73)

Author: stanlp1

spec/urlHelpers.test.tsx

@@ -72,17 +72,6 @@ describe('Testing Default UrlHelpers: getUrlFromState', () => {
     expect(params.has(testRequestState.filterName)).toBe(false);
     expect(params.has(testRequestState.filterValue)).toBe(false);
   });
-
-  test('Should encode filterName and filterValue as part of the path', () => {
-    const urlString = getUrlFromState(testRequestState as RequestConfigs, {
-      baseUrl: 'https://www.example.com/a/random/path',
-    });
-    const url = new URL(urlString);
-    const paths = url.pathname.split('/');
-
-    expect(paths.indexOf(testRequestState.filterName)).not.toBe(-1);
-    expect(paths.indexOf(testRequestState.filterValue)).not.toBe(-1);
-  });
 });
 
 describe('Testing Default UrlHelpers: getStateFromUrl', () => {

spec/useBrowseResults.test.js

@@ -57,7 +57,7 @@ describe('Testing Hook: useBrowseResults', () => {
 
     const url = getUrlFromState(
       { filterValue: '123', filters, resultsPerPage, page },
-      { baseUrl: 'https://example.com/browse/' },
+      { baseUrl: 'https://example.com/browse/123' },
     );
     mockLocation.href = url;
 

src/utils/urlHelpers.ts

@@ -131,10 +131,5 @@ export function getUrlFromState(
     }
   });
 
-  let groupPath = '';
-  if (state.filterValue) {
-    groupPath = `/${state.filterName}/${state.filterValue}`;
-  }
-
-  return `${baseUrl}${groupPath}?${params.toString()}`;
+  return `${baseUrl}?${params.toString()}`;
 }