Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config provider to fix spec config api #8919

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Fix config provider to fix spec config api #8919

merged 3 commits into from
Dec 13, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Dec 13, 2024

This brings back all missing values from the spec config api

related to #8917

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr changed the title Fix config provider Fix config provider to fix spec config api Dec 13, 2024
StefanBratanov
StefanBratanov approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess also could add a line in the CHANGELOG

@tbenr tbenr enabled auto-merge (squash) December 13, 2024 09:48
@tbenr tbenr merged commit 6b07218 into Consensys:master Dec 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbenr @rolfyone @StefanBratanov