Refactor ExecutionPayloadResult #8702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
force-pushed
the
refactor_execution_payload_result
branch
from
86b0076 to
e4bbe67
Compare
gfukushima
approved these changes
Oct 10, 2024
The description wasn't worded properly. Updated it now. Basically, when using the builder flow and we fallback to local we store the whole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
It is a bit inconsistent to have the
GetPayloadResponsefields separate for the local flow but store the wholeGetPayloadResponseinFallbackDatafor the builder flow.The refactor will also help to make it easier when new fields are added to
GetPayloadResponse.Fixed Issue(s)
N/A
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog