In SpecVersion, make SpecConfig instance consistent with milestone
#8830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
force-pushed
the
SpecConfigAndParent
branch
from
e6efa54 to
7326bb6
Compare
tbenr
changed the title
SpecVersion, make SpecConfig instance consistent with milestone
tbenr
force-pushed
the
SpecConfigAndParent
branch
2 times, most recently
from
e6028d7 to
224e798
Compare
tbenr
force-pushed
the
SpecConfigAndParent
branch
from
464bcfb to
6c730f6
Compare
|
|
This reverts commit 7e1da2b.
zilm13
approved these changes
Nov 14, 2024
ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/builder/BuilderChain.java
Outdated
Show resolved
Hide resolved
ethereum/spec/src/test/java/tech/pegasys/teku/spec/config/SpecConfigBuilderTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we always have the highest configured milestone
SpecConfiginstance associated to eachSpecVersion.This PR makes sure that
SpecConfigversion correspond to theSpecVersionfor a given milestone.For example, for mainnet network, we have
SpecConfigPhase0is returned when we dospec.atSlot(0).getConfig()even whenElectrais configured.Similarly for all milestones.
Fixes a counterintuitive behaviour that we frequently forget, causing wasted time, and enables some advanced usage of the SpecConfig (like abstracting away config params that are updated from a milestone to the next, like max blobs)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog