Merge Branches #47
Merged
Merge Branches #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9a164d7.
…ach sublink in the resources page.
Install eslint & prettier for debugging and formatting code
…truction Format code instruction
This fixes issue #12 which opens the corresponding tab indicated by e…
- useState was imported twice - toggleTab was defined twice
Will be used in later features
- Update resources css to include contents animation and effect for tab buttons - Reconfigure Resources.js to use updated resources css
Apply Prettier formatting to entire project
- Different structure is being directly implemented from NavigationBar.js
- FIle no longer needed. Will implement directly in Activity files
Also removed unnecessary empty text
- NavBar and Activity file cleanup - Certain files and functions no longer needed due to changed implementation of NavigationBar.js - Unnecessary comments removed from Activity.js
- Type-safe equality operators are preferred
- A lone div with "onClick" must have some role to add interactivity - Buttons must be focusable by having a tabIndex that lets users reach the element by pressing tab
This PR adds dummy data in activity page for testing its ui.
Apply linter rules
…ta-activity Reformat fakeData for activity using prettier rules
- Incorporate eslint, prettier, and windows/mac builds - Fail-fast is set to false so tests on all OS's are run before stopping
- We don't have any tests, and we only need to test if the app will build here
Create Github Actions file to test builds before merging
Replace website's background image with solid black color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.