Skip to content

Conversation

@minhngo3818
Copy link
Collaborator

This PR makes Resources page responsive with both browser & mobile. This latest design for Resources page will be consistent through out the project. The update includes tab contents animation, and effect for tab buttons. All changes in this PR are formatted by prettier. It still needs data for testing #14. The PR solves #11, #13

Demo

Responsive Feature

@minhngo3818 minhngo3818 added CSS require using css Resources-page resouces page Frontend task relates to frontend fix fix bug labels Jul 26, 2022
@minhngo3818 minhngo3818 requested a review from 2mnguyen1 July 26, 2022 04:55
@minhngo3818 minhngo3818 self-assigned this Jul 26, 2022
@KHVBui KHVBui self-requested a review July 31, 2022 22:52
@minhngo3818 minhngo3818 removed the request for review from 2mnguyen1 August 1, 2022 02:30
Copy link
Collaborator

@KHVBui KHVBui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Declaration of useState on line 1 already exists on line 3
  • Duplicate assignment of toggleTab on line 20 and 29

- useState was imported twice
- toggleTab was defined twice
Will be used in later features
@KHVBui KHVBui merged commit 7fee78a into Computer-Science-Club-OCC:main Aug 1, 2022
@minhngo3818 minhngo3818 deleted the resources-css branch August 1, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS require using css fix fix bug Frontend task relates to frontend Resources-page resouces page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants