Create Github Actions file to test builds before merging #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KHVBui
added
not ready PR
minhngo3818
reviewed
Aug 1, 2022
KHVBui
changed the title
KHVBui
force-pushed
the
Build-Test-for-CI
branch
from
0bc816d to
96dbd71
Compare
|
Going to need a Lint fix PR before merging this PR |
KHVBui
force-pushed
the
Build-Test-for-CI
branch
from
ffdf27d to
0711910
Compare
- Incorporate eslint, prettier, and windows/mac builds - Fail-fast is set to false so tests on all OS's are run before stopping
KHVBui
force-pushed
the
Build-Test-for-CI
branch
from
0711910 to
96c9038
Compare
- We don't have any tests, and we only need to test if the app will build here
|
PHEW I finally got the workflow to work. There was this fun bug where it didn't work on the windows build since windows uses a different eol character, but adding a gitattributes file to do eol normalization fixed it |
|
Sweet! Once this PR merged, we're going use this workflow to check every PRs. |
|
Can you make the accepting review to merge? xD |
minhngo3818
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.