[fix] Bypass Nx for i18n collection TypeScript compilation #5278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change collect-i18n command from 'nx e2e' to 'npx playwright test' to use Playwright's native TypeScript compilation instead of Nx's pipeline. Nx's compilation pipeline doesn't properly handle TypeScript 'declare' fields in LiteGraph source files, causing babel transform errors. Playwright's native compilation handles these correctly. This addresses the TypeScript compilation error: 'declare fields must first be transformed by @babel/plugin-transform-typescript' Fixes remaining issue after previous workflow fixes.
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status❌ Build failed! ⏰ Completed at: 08/31/2025, 03:14:48 AM UTC 🔗 Links |
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/31/2025, 03:37:55 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
snomiao
approved these changes
Aug 31, 2025
snomiao
pushed a commit
that referenced
this pull request
Aug 31, 2025
) Change collect-i18n command from 'nx e2e' to 'npx playwright test' to use Playwright's native TypeScript compilation instead of Nx's pipeline. Nx's compilation pipeline doesn't properly handle TypeScript 'declare' fields in LiteGraph source files, causing babel transform errors. Playwright's native compilation handles these correctly. This addresses the TypeScript compilation error: 'declare fields must first be transformed by @babel/plugin-transform-typescript' Fixes remaining issue after previous workflow fixes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix TypeScript compilation error in i18n collection by bypassing Nx compilation pipeline and using Playwright's native TypeScript handling.
Problem
After the PNPM/Nx migration, the i18n workflow fails with:
This occurs because:
playwright testused Playwright's native TypeScript compilationnx e2e --config=playwright.i18n.config.tsroutes through Nx's compilation pipelinedeclarefields in LiteGraph source filesSolution
Change the
collect-i18ncommand from:To:
This bypasses Nx and uses Playwright's native TypeScript compilation, which handles
declarefields correctly.This is the third and hopefully final fix for the i18n workflow after PRs #5266 and #5270.
┆Issue is synchronized with this Notion page by Unito