[fix] Update i18n workflow for PNPM/Nx compatibility #5266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove explicit file arguments from collect-i18n command as the new Nx e2e setup uses playwright config with testMatch pattern to automatically find test files. The command 'pnpm collect-i18n -- scripts/collect-i18n-general.ts' was failing because Nx e2e doesn't accept file arguments in the same way. Fixes workflow failure in release PR #5263
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status⏳ Build is starting... ⏰ Started at: 08/30/2025, 08:33:51 PM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
🎨 Storybook Build Status❌ Build failed! ⏰ Completed at: 08/30/2025, 08:33:51 PM UTC 🔗 Links |
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/30/2025, 08:57:15 PM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
This was referenced Aug 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix i18n workflow failing due to incompatible command arguments after PNPM/Nx migration.
Changes
pnpm collect-i18ncommandtestMatch: /collect-i18n-.*\.ts/to automatically find test filesProblem
The command
pnpm collect-i18n -- scripts/collect-i18n-general.tswas failing because the new Nx e2e setup doesn't accept file arguments in the same way as the previous setup.Solution
Use
pnpm collect-i18nwithout arguments, letting the playwright config handle test discovery.Fixes workflow failure in release PR #5263
┆Issue is synchronized with this Notion page by Unito