[fix] Use defineConfig for i18n Playwright config TypeScript compilation #5270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpilation Update playwright.i18n.config.ts to use defineConfig() instead of PlaywrightTestConfig interface to fix TypeScript compilation issues with 'declare' fields. The defineConfig API provides proper Vite integration for TypeScript/Babel compilation, fixing the error: 'TypeScript declare fields must first be transformed by @babel/plugin-transform-typescript' Fixes compilation error in i18n collection workflow.
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status❌ Build failed! ⏰ Completed at: 08/30/2025, 10:07:34 PM UTC 🔗 Links |
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/30/2025, 10:30:41 PM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
Contributor
Author
|
Merging so I can unblock release. Feel free to review/comment still and I'll address in followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix TypeScript compilation error in i18n collection workflow by updating
playwright.i18n.config.tsto use moderndefineConfigAPI.Problem
The i18n workflow was failing with:
This occurred because
playwright.i18n.config.tswas using the olderPlaywrightTestConfiginterface instead ofdefineConfig()which provides proper Vite integration for TypeScript compilation.Solution
PlaywrightTestConfiginterface withdefineConfig()APIplaywright.config.tswhich already usesdefineConfigFixes the remaining issue after PR #5266
┆Issue is synchronized with this Notion page by Unito