-
Notifications
You must be signed in to change notification settings - Fork 447
Re-Route Support to Zendesk #5259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/02/2025, 05:57:45 PM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
|
Did you try using |
Yeah, used knip for my last commit. |
christian-byrne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the translation keys submitErrorReport, feedbackTitle, and contactSupportTitle seem to remainin some locale files.
christian-byrne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request removes the in-app error report form and its related components, tests, and logic. The user interface and test flows are updated to reflect this removal, and the support workflow now directs users to an external support link instead of the previous feedback dialog.
Removal of error reporting functionality:
IssueReportDialogContent.vuecomponent, which previously provided the in-app error report form.ReportIssuePanel.spec.tstest file, eliminating all unit tests related to the error report panel.ReportIssuePanelcomponent and all logic related to displaying or handling the error report form fromErrorDialogContent.vue, including associated imports, state, and UI elements. [1] [2] [3] [4] [5]Updates to end-to-end/browser tests:
dialog.spec.ts.Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito