Skip to content

Conversation

@Myestery
Copy link
Collaborator

@Myestery Myestery commented Aug 30, 2025

This pull request removes the in-app error report form and its related components, tests, and logic. The user interface and test flows are updated to reflect this removal, and the support workflow now directs users to an external support link instead of the previous feedback dialog.

Removal of error reporting functionality:

  • Deleted the IssueReportDialogContent.vue component, which previously provided the in-app error report form.
  • Removed the ReportIssuePanel.spec.ts test file, eliminating all unit tests related to the error report panel.
  • Removed the ReportIssuePanel component and all logic related to displaying or handling the error report form from ErrorDialogContent.vue, including associated imports, state, and UI elements. [1] [2] [3] [4] [5]

Updates to end-to-end/browser tests:

  • Removed the test that verified the display of the Issue Report form after an execution error in dialog.spec.ts.
  • Updated the feedback dialog tests: replaced the feedback dialog flow with a new test that verifies opening an external Zendesk support link from the top menu, and removed tests related to the old feedback dialog.

Screenshots (if applicable)

┆Issue is synchronized with this Notion page by Unito

@github-actions
Copy link

github-actions bot commented Aug 30, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/02/2025, 05:57:45 PM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

@Myestery Myestery marked this pull request as ready for review September 1, 2025 01:26
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 1, 2025
@christian-byrne
Copy link
Contributor

Did you try using knip? I'm pretty sure there's still some other cleanup like the report zod schema possibly?

@Myestery
Copy link
Collaborator Author

Myestery commented Sep 1, 2025

Did you try using knip? I'm pretty sure there's still some other cleanup like the report zod schema possibly?

Yeah, used knip for my last commit.
helped me find that unused IssueReportSchema

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the translation keys submitErrorReport, feedbackTitle, and contactSupportTitle seem to remainin some locale files.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 2, 2025
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-byrne christian-byrne merged commit 8f7ee4e into main Sep 2, 2025
14 checks passed
@christian-byrne christian-byrne deleted the feat-support-helpdesk-change branch September 2, 2025 18:02
@benceruleanlu benceruleanlu mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants