Skip to content

Commit 8f7ee4e

Browse files
authored
Re-Route Support to Zendesk (#5259)
* refactor: replace feedback command with contact support in Help Center menu * refactor: replace feedback dialog with external support link in Help menu * refactor: simplify error reporting UI by removing send report functionality * refactor: remove issue report dialog and update support contact method * refactor: remove IssueReportDialog and associated components * refactor: remove unused issue report schema * refactor: remove unused issue report types * refactor: remove unused issue report fields from localization files
1 parent b091f3a commit 8f7ee4e

File tree

21 files changed

+25
-1207
lines changed

21 files changed

+25
-1207
lines changed

browser_tests/tests/dialog.spec.ts

Lines changed: 8 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,6 @@ test.describe('Execution error', () => {
5959
const executionError = comfyPage.page.locator('.comfy-error-report')
6060
await expect(executionError).toBeVisible()
6161
})
62-
63-
test('Can display Issue Report form', async ({ comfyPage }) => {
64-
await comfyPage.loadWorkflow('nodes/execution_error')
65-
await comfyPage.queueButton.click()
66-
await comfyPage.nextFrame()
67-
68-
await comfyPage.page.getByLabel('Help Fix This').click()
69-
const issueReportForm = comfyPage.page.getByText(
70-
'Submit Error Report (Optional)'
71-
)
72-
await expect(issueReportForm).toBeVisible()
73-
})
7462
})
7563

7664
test.describe('Missing models warning', () => {
@@ -303,37 +291,16 @@ test.describe('Settings', () => {
303291
})
304292
})
305293

306-
test.describe('Feedback dialog', () => {
307-
test('Should open from topmenu help command', async ({ comfyPage }) => {
308-
// Open feedback dialog from top menu
294+
test.describe('Support', () => {
295+
test('Should open external zendesk link', async ({ comfyPage }) => {
309296
await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
310-
await comfyPage.menu.topbar.triggerTopbarCommand(['Help', 'Feedback'])
311-
312-
// Verify feedback dialog content is visible
313-
const feedbackHeader = comfyPage.page.getByRole('heading', {
314-
name: 'Feedback'
315-
})
316-
await expect(feedbackHeader).toBeVisible()
317-
})
318-
319-
test('Should close when close button clicked', async ({ comfyPage }) => {
320-
// Open feedback dialog
321-
await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
322-
await comfyPage.menu.topbar.triggerTopbarCommand(['Help', 'Feedback'])
323-
324-
const feedbackHeader = comfyPage.page.getByRole('heading', {
325-
name: 'Feedback'
326-
})
327-
328-
// Close feedback dialog
329-
await comfyPage.page
330-
.getByLabel('', { exact: true })
331-
.getByLabel('Close')
332-
.click()
333-
await feedbackHeader.waitFor({ state: 'hidden' })
297+
const pagePromise = comfyPage.page.context().waitForEvent('page')
298+
await comfyPage.menu.topbar.triggerTopbarCommand(['Help', 'Support'])
299+
const newPage = await pagePromise
334300

335-
// Verify dialog is closed
336-
await expect(feedbackHeader).not.toBeVisible()
301+
await newPage.waitForLoadState('networkidle')
302+
await expect(newPage).toHaveURL(/.*support\.comfy\.org.*/)
303+
await newPage.close()
337304
})
338305
})
339306

src/components/dialog/content/ErrorDialogContent.vue

Lines changed: 1 addition & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,9 @@
2121
@click="showReport"
2222
/>
2323
<Button
24-
v-show="!sendReportOpen"
25-
text
26-
:label="$t('issueReport.helpFix')"
27-
@click="showSendReport"
28-
/>
29-
<Button
30-
v-if="authStore.currentUser"
3124
v-show="!reportOpen"
3225
text
33-
:label="$t('issueReport.contactSupportTitle')"
26+
:label="$t('issueReport.helpFix')"
3427
@click="showContactSupport"
3528
/>
3629
</div>
@@ -41,16 +34,6 @@
4134
</ScrollPanel>
4235
<Divider />
4336
</template>
44-
<ReportIssuePanel
45-
v-if="sendReportOpen"
46-
:title="$t('issueReport.submitErrorReport')"
47-
:error-type="error.reportType ?? 'unknownError'"
48-
:extra-fields="[stackTraceField]"
49-
:tags="{
50-
exceptionMessage: error.exceptionMessage,
51-
nodeType: error.nodeType ?? 'UNKNOWN'
52-
}"
53-
/>
5437
<div class="flex gap-4 justify-end">
5538
<FindIssueButton
5639
:error-message="error.exceptionMessage"
@@ -81,18 +64,12 @@ import { useCopyToClipboard } from '@/composables/useCopyToClipboard'
8164
import { api } from '@/scripts/api'
8265
import { app } from '@/scripts/app'
8366
import { useCommandStore } from '@/stores/commandStore'
84-
import { useFirebaseAuthStore } from '@/stores/firebaseAuthStore'
8567
import { useSystemStatsStore } from '@/stores/systemStatsStore'
86-
import type { ReportField } from '@/types/issueReportTypes'
8768
import {
8869
type ErrorReportData,
8970
generateErrorReport
9071
} from '@/utils/errorReportUtil'
9172
92-
import ReportIssuePanel from './error/ReportIssuePanel.vue'
93-
94-
const authStore = useFirebaseAuthStore()
95-
9673
const { error } = defineProps<{
9774
error: Omit<ErrorReportData, 'workflow' | 'systemStats' | 'serverLogs'> & {
9875
/**
@@ -114,10 +91,6 @@ const reportOpen = ref(false)
11491
const showReport = () => {
11592
reportOpen.value = true
11693
}
117-
const sendReportOpen = ref(false)
118-
const showSendReport = () => {
119-
sendReportOpen.value = true
120-
}
12194
const toast = useToast()
12295
const { t } = useI18n()
12396
const systemStatsStore = useSystemStatsStore()
@@ -126,15 +99,6 @@ const title = computed<string>(
12699
() => error.nodeType ?? error.exceptionType ?? t('errorDialog.defaultTitle')
127100
)
128101
129-
const stackTraceField = computed<ReportField>(() => {
130-
return {
131-
label: t('issueReport.stackTrace'),
132-
value: 'StackTrace',
133-
optIn: true,
134-
getData: () => error.traceback
135-
}
136-
})
137-
138102
const showContactSupport = async () => {
139103
await useCommandStore().execute('Comfy.ContactSupport')
140104
}

src/components/dialog/content/IssueReportDialogContent.vue

Lines changed: 0 additions & 33 deletions
This file was deleted.

0 commit comments

Comments
 (0)