Knip: Enable more rules #5309
Merged
Knip: Enable more rules #5309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/04/2025, 01:36:23 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
DrJKL
force-pushed
the
drjkl/separate-tines
branch
2 times, most recently
from
8a50abf to
79a98a0
Compare
DrJKL
force-pushed
the
drjkl/separate-tines
branch
2 times, most recently
from
67c229a to
f2f7b04
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
DrJKL
added
the
New Browser Test Expectations
DrJKL
force-pushed
the
drjkl/separate-tines
branch
from
10a627e to
37eb000
Compare
Contributor
|
Feel free to merge it! |
Contributor
Author
|
Rebasing now :-) |
DrJKL
force-pushed
the
drjkl/separate-tines
branch
from
f05a1d6 to
53fa952
Compare
christian-byrne
approved these changes
Sep 4, 2025
Merged
Merged
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
* knip: Simplify config * knip: enable unlisted, fix issues * knip: Add ignore for build dependencies (Vite plugin indirect reference) * knip: Prune dependencies * knip: One more Unused dep * git: Standard line end for yaml * [auto-fix] Apply ESLint and Prettier fixes * knip: Add exceptions for tailwindcss post-rebase. Not sure why we need to except it. * Update test expectations [skip ci] --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable unused or unlisted dependency checking.
Fix the existing violations.
Changes
Review Focus
I checked things like build/typecheck/storybook/vitest/playwright, but if some of these are used in other scripts that aren't currently analyzed we might have to add them back in and explicitly ignore them.
┆Issue is synchronized with this Notion page by Unito