LONDON | ITP-MAY-25 | TEWODROS BEKERE | Coursework/sprint 2 #540

iteddy16 · 2025-06-13T18:09:49Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

In this Sprint 2 exercise, I fix errors in the code and debug codes.

Questions

Ask any questions you have for your reviewer.

This reverts commit 01079c2.

Amundeep-Dhaliwal

Hello Tewodros, hope you are well.

Thank you for your patience and submitting this work. I have only reviewed the sprint 2 work.

It is good practice to have multiple pull requests for different pieces of work.

Amundeep-Dhaliwal · 2025-07-02T14:03:15Z

Sprint-2/1-key-errors/0.js

 // =============> write your new code here
+// Here is the corrected function:
+function capitalise(str) {
+  str = `${str[0].toUpperCase()}${str.slice(1)}`;


Reusing the same variable name solves this issue. Looks good.

Bear in mind for a more complicated program it could be confusing to reuse the same variables.

Amundeep-Dhaliwal · 2025-07-02T14:04:38Z

Sprint-2/1-key-errors/2.js

 // Finally, correct the code to fix the problem

 // =============> write your new code here
+function square(num) {


Adding the parameter is good

Amundeep-Dhaliwal · 2025-07-02T14:09:41Z

Sprint-2/2-mandatory-debug/2.js

 // Finally, correct the code to fix the problem
 // =============> write your new code here
+function getLastDigit(num) {
+  return num.toString().slice(-1);


Recognising that we need a parameter here was the main exercise, good job.

It would be nice for you to remove the const num = 103 on line 9.
You could test getLastDigit with the numbers from above?

Thank you, I removed it.

Amundeep-Dhaliwal · 2025-07-02T14:10:20Z

Sprint-2/3-mandatory-implement/1-bmi.js

 function calculateBMI(weight, height) {
-    // return the BMI of someone based off their weight and height
-}
+  const bmi = weight / (height * height);


This looks good.

Amundeep-Dhaliwal · 2025-07-02T14:13:18Z

Sprint-2/3-mandatory-implement/2-cases.js

+}
+
+// Example usage:
+console.log(toUpperSnakeCase("lord of the rings")); // Output: "HELLO_THERE"


The function works as expected, nice one.

Remember to update the comment with the updated output.

I fixed the comment part with the updated output.

Amundeep-Dhaliwal · 2025-07-02T14:25:21Z

Sprint-2/4-mandatory-interpret/time-format.js


 // b) What is the value assigned to num when pad is called for the first time?
 // =============> write your answer here
+// 1, which is the value of totalHours when seconds is 61


The first time pad is called with the totalHours input, the num parameter has the value of 0.

Thank you for the correction. I think this is how it is executed.

Amundeep-Dhaliwal · 2025-07-02T14:26:53Z

Sprint-2/4-mandatory-interpret/time-format.js

 // c) What is the return value of pad is called for the first time?
 // =============> write your answer here
+// "01", because pad converts the number 1 to a string and pads it with a leading zero to make it two characters long
+// Call formatTimeDisplay with an input of 3661, now answer the following:


Thinking outside of the box for this one.

I fixed my error in here.

Amundeep-Dhaliwal · 2025-07-02T14:28:03Z

Sprint-2/4-mandatory-interpret/time-format.js


 // c) What is the return value of pad is called for the first time?
 // =============> write your answer here
+// "01", because pad converts the number 1 to a string and pads it with a leading zero to make it two characters long


pad(totalHours) would have the return value of "00"

Amundeep-Dhaliwal · 2025-07-02T14:30:44Z

Sprint-2/4-mandatory-interpret/time-format.js


 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> write your answer here
+// 1, which is the value of remainingSeconds when seconds is 3661. The totalHours is 1, remainingMinutes is 1, and remainingSeconds is 1.


The output when pad is called for the last time in this program is "01".

As you said remainingSeconds has the value of 1.

Amundeep-Dhaliwal · 2025-07-02T14:46:47Z

Sprint-2/5-stretch-extend/format-time.js

+console.assert(
+  currentOutput3 === targetOutput3,
+  `current output: ${currentOutput3}, target output: ${targetOutput3}`
+);


Well done for completing the extension here.
This solution works for the test cases that you have defined.

A point to consider for this program:

Inputting 12:00 gives 12:00 am as the output, 12:00 in 24 hour time is noon.

Only for reference, here is a tested example that also handles minutes:

function pad(num) { //adds leading 0s to string until it reaches length 2 return num.toString().padStart(2, "0"); } function formatAs12HourClock(time) { if (!/^(0[0-9]|1[0-9]|2[0-3]):[0-5][0-9]$/.test(time)) { //if string DOESN'T look like HH:MM, min 00:00/max 23:59 console.log(`You entered "${time}". formatAs12HourClock only works for times written HH:MM. min 00:00, max 23:59.`); return; } let suffix = "" let hours = Number(time.slice(0,2)); //convert to number to enable comparisons in if statement const mins = time.slice(3); if (hours==0) { // if time entered was 00:MM, then it's midnight and the time has just flipped to am hours = 12; // in 12 hours clock, 00 is not allowed, so add 12 => 12:00 am for midnight suffix = "am" } else if (hours<12) { // hours 1 through 11 are am hours suffix = "am" } else if (hours==12) { // at midday, the time flips to pm suffix = "pm" } else { // hours > 12 => time is in the afternoon/night hours=hours-12; suffix = "pm" } return `${pad(hours)}:${mins} ${suffix}` } const testStrings = { "08:00":"08:00 am", "23:00":"11:00 pm", "12:00": "12:00 pm", "13:15": "01:15 pm", "11:11": "11:11 am", "03:15": "03:15 am", "00:05": "12:05 am", "00:00": "12:00 am", } for (const [input, output] of Object.entries(testStrings)){ const currentOutput = formatAs12HourClock(input); console.assert( output === currentOutput, `input: ${input} desired output: ${output}, actual output: ${currentOutput}` ) }

iteddy16 · 2025-07-03T17:59:21Z

Thank you @Amundeep-Dhaliwal for your insightful review, I addressed all the raised issues.

Amundeep-Dhaliwal · 2025-07-04T16:48:07Z

Hello Tewodros,

Thanks for making improvements and your screenshots. From a sprint 2 perspective this PR is complete.

Can you please raise a new PR with all the sprint 3 work?

iteddy16 · 2025-07-04T21:18:57Z

@Amundeep-Dhaliwal, here is my Sprint-3 PR link. The reason my first part of Sprint 3 was included in Sprint 2 was that I forgot to change my branch from Sprint 2 to Sprint 3.
Here is my Sprint-3 PR Link: #602
Thank you,

iteddy16 added 12 commits June 13, 2025 10:28

answered sprint-2 0.js

bafaee8

answered 1-key-errors 1.js

ea11210

answered 1-key-errors 2.js

9b714c8

answered 2-mandatory-debug 0.js

9b5c5d4

update 0.js

1640e2c

answered 2-mandatory-debug 1.js

1537baf

answered 2-mandatory-debug 2.js

d79a1ca

answered 3-mandatory-implement / 1-bmi.js

7a35859

answered 3-mandatory-implement/2-cases.js

6b2be6c

update 3-mandatory-implement/3-to-pounds.js

dc3b4e8

answered 4-mandatory-interpret/time-format.js

aa1f8ee

update 5-stretch-extend

62bba09

iteddy16 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 13, 2025

iteddy16 added 9 commits June 24, 2025 13:49

Updated Sprint-2/ 1.js

95332ed

Update Sprint-3\2\2-is-proper-fraction.js

01079c2

Update 2-is-proper-fraction.test.js

e4425d9

updated Sprint-3\2\3-get-card-value and test.js

de2a5de

update sprint-3\3\count.js and count.test.js

e3ebe30

update sprint-3\3\get-ordinal-number.js

6e88202

Add additional test cases for getOrdinalNumber function

376d990

update Sprint-3\3\repeat.js and repeat.test.js

1593416

Revert "Update Sprint-3\2\2-is-proper-fraction.js"

ba26a99

This reverts commit 01079c2.

iteddy16 mentioned this pull request Jun 27, 2025

Step 2 Submission iteddy16/My-Coursework-Planner#53

Open

Amundeep-Dhaliwal reviewed Jul 2, 2025

View reviewed changes

Amundeep-Dhaliwal added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 2, 2025

iteddy16 added 4 commits July 3, 2025 17:32

Update for review mandatory debug 2.js

9a7b904

updated for review mandatory implement 2-cases.js

09838ac

updates for review mandatory implement 3-to-pound.js

e7ceb40

updated for review mandatory-interpret time-format.js

46a7807

Amundeep-Dhaliwal added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 4, 2025

illicitonion closed this Sep 1, 2025

Uh oh!

LONDON | ITP-MAY-25 | TEWODROS BEKERE | Coursework/sprint 2 #540

LONDON | ITP-MAY-25 | TEWODROS BEKERE | Coursework/sprint 2 #540

Uh oh!

Conversation

iteddy16 commented Jun 13, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

Amundeep-Dhaliwal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iteddy16 commented Jul 3, 2025

Uh oh!

Amundeep-Dhaliwal commented Jul 4, 2025

Uh oh!

iteddy16 commented Jul 4, 2025

Uh oh!

Uh oh!