LONDON | ITP-MAY-25 | TEWODROS BEKERE | Coursework/sprint-3 #602

iteddy16 · 2025-06-24T23:22:19Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Fix the code for angle type, proper fraction, and get the card value by modifying the code for the testing run. Also, respond to the question raised in the comment section of each folder.

Questions

Ask any questions you have for your reviewer.

…-3\4\card-validator.js

Amundeep-Dhaliwal

Hello Tewodros, hope you are well.

Thanks for submitting this work, please see the comments.

Amundeep-Dhaliwal · 2025-07-08T13:28:57Z

Sprint-3/1-key-implement/1-get-angle-type.js

+    if (angle > 180 && angle < 360) return "Reflex Angle";
+    if( angle < 0 || angle > 360)
+    return "Invalid Angle"; // This handles angles outside the 0-360 range 
+    if(angle === 0 || angle === 360) 


This function looks good.

Could you use the conditional angle <= 0 || angle >= 360 to decide whether the parameter is an "Invalid Angle"?

Yes, it works for < 0 and exact 0 and >360 and exact 360 returns invalid.

Amundeep-Dhaliwal · 2025-07-08T13:37:02Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

+  // If you want to handle negative fractions, you can also add a case for that.
+  // If you want to handle fractions where the numerator is equal to the denominator,
+  // you can also add a case for that.
+  // If you want to handle fractions that are not numbers, you can also add a case for that.


I see that you have added comments for handling edge cases for this function, seems like your requirements are well defined.

Perhaps this would be a good stretch for you to introduce logic for handling the denominator being zero.

How would you handle the situation where the numerator is -4 & the denominator is 3?

I added the zero denominator to throw an error, and for this logic (-4, 3) it's handled by ' if (numerator < denominator) return true;'

Thank you for adding that check to make sure the denominator is non-zero.

Amundeep-Dhaliwal · 2025-07-08T13:41:23Z

Sprint-3/1-key-implement/3-get-card-value.js

 // Then it should return the numerical card value
-const aceofSpades = getCardValue("A♠");
-assertEquals(aceofSpades, 11);
+const ace_of_Spades = getCardValue("A♠");


In Javascript it is common to use the camel case naming convention, aceOfSpades.

In python it is common to use the snake case naming convention for variables e.g. ace_of_spades.

I have updated all to the correct form.

Amundeep-Dhaliwal · 2025-07-08T15:46:37Z

Sprint-3/1-key-implement/3-get-card-value.js

 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+function getCardValue(card) {


This function is implemented well.

Replacing the getCardValue function at the top of this file with this one would be good.

I replaced the above getCardValue function.

Amundeep-Dhaliwal · 2025-07-08T15:55:21Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  }else if (angle > 180 && angle < 360) { 


This function looks good and covers the requirements. Nice job.

The two checks for angle > 90 and angle > 180 are not necessary.

I updated the function to address all the comments to look like this, and I tested it for all possible outputs, and it works.

This satisfies the criteria.

Amundeep-Dhaliwal · 2025-07-08T16:47:33Z

Sprint-3/4-stretch-investigate/card-validator.js

+
+  // All checks passed, return true
+  return true;
+}


This implementation looks elegant, nice to stretch your capabilities.

Amundeep-Dhaliwal · 2025-07-08T16:49:50Z

Sprint-3/4-stretch-investigate/find.js


 // a) How the index variable updates during the call to find
+
+// The index commences at 0 and is incremented by 1 on each iteration of the loop via the use of the index operator (++).


Did you mean increment operator?

I updated with a clearer statement like this:

Amundeep-Dhaliwal · 2025-07-08T16:52:37Z

Sprint-3/4-stretch-investigate/find.js

+
 // b) What is the if statement used to check
+
+// The function performs a comparison of the current character in the string (str[index]) with the character specified in the search parameter.


This answer is correct, did you mean condition instead of function here?

Yes, function is always in my mind, that's why. I updated it like this:

Amundeep-Dhaliwal · 2025-07-08T16:55:40Z

Sprint-3/4-stretch-investigate/password-validator.js

+  if (previousPasswords.includes(password)) return false;
+
+  // If all checks pass, the password is valid
+  return true;


This looks good, you covered all the requirements for this function.

I like how you used previousPasswords as an optional parameter.

Amundeep-Dhaliwal · 2025-07-08T16:57:55Z

Sprint-3/4-stretch-investigate/password-validator.test.js

+    const previousPasswords = ["Test@123", "Test123!"];
+    const result = isValidPassword(password, previousPasswords);
+    expect(result).toEqual(true);
+});


These tests for isValidPassword look comprehensive. Nice one.

…t-card-value

iteddy16 · 2025-07-09T20:00:37Z

@Amundeep-Dhaliwal Thank you for your detailed review and comments, I addressed the point raised in the PR and also here in the comments to make it easier to look I put the screenshots.

Amundeep-Dhaliwal · 2025-07-11T16:03:16Z

Thanks for the updates & screenshots Tewodros.

iteddy16 added 15 commits June 13, 2025 19:33

update 1-key-implement/1-get-angle-type.js

9167e67

1-key-implement/2-is-proper-fractions.js

f9da79b

1-key-implement/3-get-card-values.js

da2169b

update sprint-1 1-key-exercise/1-count.js

6894bd8

Sprint-3/1-key-implement/1-get-angle-type.js

cb1730c

Updated Sprint-3\2\1-get-angle-type.js

55d8c9f

Updated Sprint-3\2-mandatory-rewrite\1-get-angle-type and test.js

3a6390e

update sprint-3\2\2-is-proper-fraction.js and test

796a8cf

update sprint-3\2\3-get-card-values.js and test.js

b014b98

update sprint-3\3\count.js and count.test.js

7e10cb8

update sprint-3\3\get-ordinal-number.js and test.js

0771e60

update Sprint-3\3\repeat.js and repeat.test.js

c8ed1bb

add card-validator.js for credit card validation functionality sprint…

e9ab61e

…-3\4\card-validator.js

update sprint-3\4\find.js

04360b4

update sprint-3\4\password-validator.js

ce4fb74

iteddy16 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 24, 2025

iteddy16 mentioned this pull request Jun 27, 2025

Step 2 Submission iteddy16/My-Coursework-Planner#53

Open

iteddy16 mentioned this pull request Jul 4, 2025

LONDON | ITP-MAY-25 | TEWODROS BEKERE | Coursework/sprint 2 #540

Closed

5 tasks

Amundeep-Dhaliwal reviewed Jul 8, 2025

View reviewed changes

iteddy16 added 7 commits July 9, 2025 18:11

Updates fro sprint-3/1-get-angle-type, 2-is-proper-fraction, and 3-ge…

63dda1e

…t-card-value

update the getCardValue function

ab8f199

updated sprint-3/1-get-angle-type

d96efd6

updates for get angle and get card

1fc4d18

update sprint-3/3-mandatory practice/count and count.test.js

3ea90b1

updates sprint-3/get-ordinal-numbers.js

76a9808

update sprint-3/find.js

5ed0d66

Amundeep-Dhaliwal added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 11, 2025

illicitonion changed the base branch from to-be-deleted-coursework/sprint-3 to main July 17, 2025 14:54

illicitonion closed this Sep 1, 2025


		// a) How the index variable updates during the call to find

		// The index commences at 0 and is incremented by 1 on each iteration of the loop via the use of the index operator (++).


		// b) What is the if statement used to check

		// The function performs a comparison of the current character in the string (str[index]) with the character specified in the search parameter.

Uh oh!

LONDON | ITP-MAY-25 | TEWODROS BEKERE | Coursework/sprint-3 #602

LONDON | ITP-MAY-25 | TEWODROS BEKERE | Coursework/sprint-3 #602

Uh oh!

Conversation

iteddy16 commented Jun 24, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

Amundeep-Dhaliwal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iteddy16 commented Jul 9, 2025

Uh oh!

Amundeep-Dhaliwal commented Jul 11, 2025

Uh oh!

Uh oh!