Update Sprint-3\2\2-is-proper-fraction.js

Author: iteddy16

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

@@ -1,6 +1,16 @@
 function isProperFraction(numerator, denominator) {
     if (numerator < denominator) return true;
     // add your completed function from key-implement here
+    //return denominator !== 0 && Math.abs(numerator) < Math.abs(denominator);
+   if (denominator === 0) return false; // Avoid division by zero
+    if (numerator === 0) return true; // Zero is considered a proper fraction
+    if (numerator < 0 || denominator < 0) return false; // Negative fractions are not proper
+    return Math.abs(numerator) < Math.abs(denominator);
+             
+
 }
 
-module.exports = isProperFraction;
+console.log(isProperFraction(0, 1)); 
+
+module.exports = isProperFraction;
+

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

@@ -2,10 +2,23 @@ const isProperFraction = require("./2-is-proper-fraction");
 
 test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
+  expect(isProperFraction(1, 2)).toEqual(true);
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for an improper fraction", () => {
+  expect(isProperFraction(5, 3)).toEqual(false);
+  expect(isProperFraction(3, 3)).toEqual(false);
+});
+
 
 // Case 3: Identify Negative Fractions:
+test("should return false for a negative fraction", () => {
+  //expect(isProperFraction(-2, 3)).toEqual(false);
+  expect(isProperFraction(2, -3)).toEqual(false);
+  expect(isProperFraction(-2, -3)).toEqual(false); // consider your spec on this one
+});
+
+
+
 
-// Case 4: Identify Equal Numerator and Denominator: