Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start making debug recipes for tests that can use them #77749

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Start making debug recipes for tests that can use them #77749

wants to merge 2 commits into from

Conversation

Maleclypse
Copy link
Member

Summary

Infrastructure "Debug recipes for tests: first"

Purpose of change

Helps to fix #75255

Describe the solution

Adds a debug recipe and makes it be used in testing.

Describe alternatives you've considered

Adding all this to the original PR it's in service to.

Testing

Additional context

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 11, 2024
@Maleclypse
Copy link
Member Author

src/recipe_dictionary.cpp:66 This is a tomorrow problem

github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
data/json/recipes/debug_recipes.json
],
"proficiencies": [ { "proficiency": "prof_millinery" }, { "proficiency": "prof_polymerworking" } ]
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
]
]

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Nov 11, 2024
@IdleSol
Copy link
Contributor

IdleSol commented Nov 11, 2024 

"id_suffix": "_debug",

?

@Procyonae
Copy link
Contributor

Shouldn't these go in /data/mods/TEST_DATA?

@Maleclypse
Copy link
Member Author

Shouldn't these go in /data/mods/TEST_DATA?

I tried that and for some reason the tests refused to find them. Which probably kills this PR honestly.

@IdleSol
Copy link
Contributor

IdleSol commented Nov 16, 2024 •
edited
Loading

Maybe because you have recipe id = helmet_scavenger. And the tests are trying to find helmet_scavenger_debug.

And to make it work you need to add a suffix. But maybe I'm wrong and the reason is something else.

Cataclysm-DDA/doc/JSON_INFO.md

Line 2128 in 2d4306f

"id_suffix": "", // Optional (default: empty string). Some suffix to make the ident of the recipe unique. The ident of the recipe is "<id-of-result><id_suffix>".

Alternatively, add the item: helmet_scavenger_debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maleclypse @IdleSol @Procyonae