Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typified lightmap #73568

Merged
merged 2 commits into from
May 9, 2024
Merged

typified lightmap #73568

merged 2 commits into from
May 9, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Introduce more typed points and tripoints to help keeping track of what data variables contain.

Describe the solution

Went through lightmap.cpp and typified it to a large extent, with side effects elsewhere taken care of.

Describe alternatives you've considered

  • Note that there is room for additional work as there are a lot of points I don't really know what they are used for (probably offsets of various types from the relative location worked on). Not addressed, as it would require actually understanding what these variables do.
  • I'm also not keen on calling relative locations "offset", as that, to me, indicates adjustments to the relative location you're working with. Not addressed.

Testing

Primitive testing in the form of loading a save and walk around a bit. Given that there should be no functional change, nothing is expected to be seen.

Additional context

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 7, 2024
@kevingranade kevingranade merged commit bf0f684 into CleverRaven:master May 9, 2024
21 of 26 checks passed
@PatrikLundell PatrikLundell deleted the typify branch May 9, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants