Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Add goblin fruit map special #72189

Merged
merged 7 commits into from
Mar 7, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Mar 5, 2024

Summary

Mods "[Xedra Evolved] Add goblin fruit map special"

Purpose of change

“We must not look at goblin men,
We must not buy their fruits:
Who knows upon what soil they fed
Their hungry thirsty roots?”

Goblin fruits have strange effects and are a fun little addition (says me, who added them), but at the moment they're limited to only Paraclesian fae because they only spawn through spells. So, there should be a way to get them out in the world.

Describe the solution

Add a map special that has some strange plants which give goblin fruits when harvested. The plants fruit in random seasons (accomplished by having four plants that look the same, one for each season). The plants just look like bushes, but they're easy to find in the forest because they glow.

Because it's currently not possible for a plant to pick an item from a list, the plants give you "mysterious fruits," which are goblin fruits in a thick shell. You have to crack the shell to get the fruit. The "mysterious fruit" has a spoil timer of 2 months, but actual goblin fruits spoil in 3 days.

Once variants are possible for terrain, these plants are going to get a bunch of wild descriptions.

Describe alternatives you've considered

Testing

Bushes spawn. They all look the same but they're variable in what seasons they can be harvested in, so it's always worthwhile to go back to a previous map special and see if new goblin fruit are ready.

At the moment, the fruit are rotten when you crack open the mysterious fruit, but #72194 will fix that.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft March 5, 2024 22:28
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Xedra Evolved Anything to do with Xedra Evolved labels Mar 5, 2024
@github-actions github-actions bot requested a review from Maleclypse March 5, 2024 22:29
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 5, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 6, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review March 6, 2024 03:36
@Maleclypse Maleclypse merged commit 6bd3a7c into CleverRaven:master Mar 7, 2024
19 of 25 checks passed
@Standing-Storm Standing-Storm deleted the goblin-grove branch March 7, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants