[Magiclysm] Parabolan wool gambesons #72054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to fix proportional warmth
The patches were the same mass as the breeches you created with 20 of them, so I divided the patch mass by 20 to make logical sense. This means that the gambeson pieces I'm making are going to take far more of the patches, but that seems fitting
The patch to garment mass ratio was all off for the pants, so I adjusted the patch's mass and have now adjusted the gambeson's patch quantities based on that mass
Adjusted per conversation on discord. .6 times the mass of cotton, or otherwise compared to wool appropriately
|
You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub. |
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
astyled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Shoot, I probably should have made those one big commit. That's my bad. |
github-actions
bot
added
json-styled
github-actions
bot
added
the
json-styled
|
But the Clang test said I needed spaces there! Fine, back to how it was before |
github-actions
bot
added
json-styled
github-actions
bot
added
the
BasicBuildPassed
|
I am behind but I will try and look at this today :) |
|
Sounds good, there's no hurry! |
|
Thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds parabolan wool armors"
Purpose of change
Parabolan wool is an incredibly bullet resistant material, it'd be a bit silly if nobody'd ever made armor out of it. And wool gambesons are right there to copy.
Describe the solution
Adjusted parabolan wool mass/volume based on a discord conversation, then created copies of wool gambesons based on that adjusted mass. Created recipes for those gambesons again based on the mass/volume adjustment of the patches. Added spawns for those gambesons in the Forge of Wonders shop, as per messages on discord. Also added a material for quilted parabolan wool, made equivalent to quilted wool proportionately.
Parabolan wool used to be 1/10th the mass of cotton, and is now 6/10ths the mass. Parabolan felt patches used to be the size of cotton sheets and are now the size of cotton patches, to match regular felt patches. Recipes for existing parabolan wool garments were changed appropriately.
Describe alternatives you've considered
Not adding these. Adjusting the material to be worse at ballistic protection and thus not make sense to make armor out of.
Testing
Clothes were wearable and craftable. Clothes protected more than adequately but not 100% completely from a CROWS turret, as expected. Clothes spawned at the Forge of Wonders and were on sale. Clothes were cut into appropriate amounts of patches.
Additional context
While this isn't my first first PR, it is absolutely the first that adds anything on this scale. I hope I have done things correctly.