Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly obsolete Railroad Station #70397

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Properly obsolete Railroad Station #70397

merged 3 commits into from
Jan 5, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Fix #68397

Describe the solution

use overmap_special_migration

Additional context

i don't know should railroad_city be obsoleted also, as it's city_building, but i think there is no harm to have it

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 23, 2023
@Maleclypse
Copy link
Member 

(all_mods)=> 22:06:48.501 ERROR : src/overmap.cpp:549 [void overmap_specials::check_consistency()] Overmap special id Railroad Station has been removed or migrated to a different type.```

@GuardianDll
Copy link
Member Author

Well shit
Does it mean we can't migrate maps if they are moved to the mod instead of being removed?

@Procyonae
Copy link
Contributor

Guess we'll have to add perfect railroad for 0.H /s
Can't you just rename the mods version?

@GuardianDll
Copy link
Member Author

i can, but then i assume i need to migrate it also, now inside the mod itself, yes?

@Procyonae
Copy link
Contributor

I don't think so, it's not very convenient to test tho

@github-actions github-actions bot added Mods Issues related to mods or modding and removed json-styled JSON lint passed, label assigned by github actions labels Jan 5, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 5, 2024
@Maleclypse Maleclypse merged commit 564fb90 into CleverRaven:master Jan 5, 2024
21 of 23 checks passed
@GuardianDll GuardianDll deleted the railroad_station_obsolete branch January 5, 2024 17:31
@Maleclypse
Copy link
Member

Thank you for all the contributions you’ve been making lately. You’ve really been on a roll.

@Procyonae Procyonae added the 0.H Backport PR to backport to the 0.H stable release canddiate label May 20, 2024
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 20, 2024
@GuardianDll @Procyonae
Properly obsolete Railroad Station (CleverRaven#70397)
d627a00 
* properly obsolete Railroad Station

* Migrate even more railroad stations

* end of line
@Procyonae Procyonae mentioned this pull request May 20, 2024
Merged
Maleclypse added a commit that referenced this pull request May 21, 2024
@Maleclypse
Merge pull request #73964 from Procyonae/Backport70397
18e3b26 
Backport #70397
@Procyonae Procyonae added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persistent invalid overmap special id after updating
3 participants
@GuardianDll @Maleclypse @Procyonae