Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra] Mad Typos, projectile accelerator describes its shape #69199

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

TheShadowFerret
Copy link
Contributor

Summary

None

Purpose of change

Saw typos while looking at #69188, and "unusual shape" doesn't explain what a projectile accelerator looks like.

Describe the solution

Fix da typos, projectile accelerator looks like a muzzle booster.
Changed pistol's booster to say "machine pistol" instead of "automatic pistol" since that phrase also refers to semi-automatic pistols.

Describe alternatives you've considered

Projectile accelerator looks like nothing in specific.

Testing

These are descriptions, what do I test 🤔

Additional context

Thought it should look like a muzzle booster because that's what the name sounds like it could do, even though they don't actually increase velocity.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Xedra Evolved Anything to do with Xedra Evolved labels Nov 9, 2023
@github-actions github-actions bot requested a review from Maleclypse November 9, 2023 04:03
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A small cylinder, reminescent of a muzzle booster. It can be mounted onto the end of your barrel, which somehow increases the speed of the projectile. It also makes the gun much louder and difficult to hold after each shot.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 9, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 9, 2023
@TheShadowFerret TheShadowFerret marked this pull request as draft November 9, 2023 11:42
@TheShadowFerret TheShadowFerret marked this pull request as ready for review November 9, 2023 12:01
Copy link
Member

@GuardianDll GuardianDll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this

@Maleclypse Maleclypse merged commit ee16c9f into CleverRaven:master Nov 10, 2023
@TheShadowFerret TheShadowFerret deleted the GeniusTypos branch November 11, 2023 00:58
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
…Raven#69199)

* [Xedra] Mad Typos, projectile accelerator looks like something

* Muzzle that thought
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants