Fix skill rust #68784
Merged
Fix skill rust #68784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Tests
ehughsbaird
force-pushed
the
fix-skill-rust
branch
from
ccf0077 to
ead4b2d
Compare
andrei8l
reviewed
Oct 21, 2023
One line too many was deleted in 88ed29d, result in skill rust no longer functioning. Restore the accidentally deleted line and add a regression test.
ehughsbaird
force-pushed
the
fix-skill-rust
branch
from
ead4b2d to
a63e666
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fix #68777
One line too many was deleted in #68490, resulting in skill rust no longer functioning.
Describe the solution
Restore the accidentally deleted line and add a regression test.
Testing
Test fails before, passes after.