Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windshields aren't just glass #63479

Closed
wants to merge 4 commits into from

Conversation

Golfavel
Copy link
Contributor

@Golfavel Golfavel commented Feb 8, 2023

Summary

Balance "Common windshields are made of tempered glass"

Purpose of change

Fixes #62998

Describe the solution

Changed standard windshields construction to use tempered glass sheets instead of standard glass sheets
Increased standard and reinforced windshields by 5x based on various sources
(1, 2, 3)
Introduced makeshift windshield vehicle part that acts just like windshields before the changes

Describe alternatives you've considered

Only changing the construction cost and increasing the durability to not hit string freeze.
Only changing the construction cost.
Dedicating more time to investigate bulletproof glass to more accurately adjust the reinforced windshields

Testing

Vehicles spawn with normal, tempered glass windshields, installing said windshields requires tempered glass sheets, and standard glass sheets can be used instead for makeshift windshields. New windshields require significantly more damage

Additional context

Needs more discussion with regards to durability changes.
More research shows that they aren't always tempered glass, and that instead they have an internal layer made of some form of plastic that actually prevents it from shattering.

changed: previous windshield parts to now be tempered glass (wip)
… new looks_like for tempered glass sheet that points to standard glass sheets
…have increased durability for balance purposes)
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 8, 2023
@Golfavel Golfavel changed the title Windshields are made of tempered glass Windshields aren't just glass Feb 9, 2023
@Boonlike
Copy link
Contributor

Boonlike commented Mar 2, 2023

If you want to get really technical, all car windows except the windshield are tempered glass. Tempering makes the glass brittle, that's why they break into little tiny bits instead of shards. Windshields are made of laminated glass, two layers pressed together on a layer of plastic. This is why the windshield doesn't collapse when a big rock hits it and maintains its shape even when it has a hole.

In my opinion your solution has the same in game effect of making the windshield more complex to build and more durable. If you wanted to go full realism, there already is laminated glass in the game and could be used instead.

@Golfavel
Copy link
Contributor Author

Golfavel commented Mar 2, 2023

Yeah, as I researched more I realized there was more to this than I had anticipated. I'll try looking at laminated glass when I get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Car windshields should be made of Tempered Glass
4 participants