Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up JSON style check in general build matrix #54375

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

Just noticed that the general build matrix also checks JSON style in the build script which uses the slow path. Could make it faster as in #54363 .

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@NetSysFire NetSysFire added Code: Build Issues regarding different builds and build environments Code: Performance Performance boosting code (CPU, memory, etc.) labels Jan 13, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 13, 2022
@kevingranade kevingranade merged commit 79fb378 into master Jan 13, 2022
@kevingranade kevingranade deleted the style-json branch January 13, 2022 22:43
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments Code: Performance Performance boosting code (CPU, memory, etc.) json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants