Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting: Colorize component selection options #53798

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Dec 27, 2021

Summary

None

Purpose of change

Fixes #53763.
After selecting a recipe with multiple alternative components, the player is prompted to select which ones to use. If some components would consume non-empty liquid containers, it's not obvious to the player which ones are problematic.

Describe the solution

Use the same magenta colour to identify selection options that would consume non-empty liquid containers:
recipe_funnel
funnel_comp_options

Describe alternatives you've considered

The linked issue suggests reordering the options, which could be done but adds quite a bit more complexity. The player can identify the options based on the matching magenta colour.

Testing

This only affects the colour of UI elements, so I figured some manual testing should be plenty.

Using the components listed in the screenshot above:

  • With 6 small plastic bottles (5 empty / 1 full) on person
    • magenta colour -> would use non-empty liquid container
  • Adding an extra empty plastic bottle to inventory
    • no magenta colour -> would not use non-empty liquid container
  • With 6 small plastic bottles (5 empty / 1 full) on the ground
    • magenta colour -> would use non-empty liquid container
  • Adding an extra empty plastic bottle on the ground
    • no magenta colour -> would not use non-empty liquid container

Additional context

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 27, 2021
@dseguin dseguin force-pushed the craft_colour_comp_selection branch from 5047d6c to 02467ff Compare December 27, 2021 21:55
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 27, 2021
@wapcaplet wapcaplet added <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Dec 28, 2021
@ZhilkinSerg ZhilkinSerg merged commit ee45afd into CleverRaven:master Dec 28, 2021
@dseguin dseguin deleted the craft_colour_comp_selection branch December 28, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty container prioritization: all the menus should prioritize them.
3 participants