Unhardcode bio_memory, add several enchantments #47656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
[C++]
ZhilkinSerg
force-pushed
the
0.F-dev
branch
2 times, most recently
from
16fb04b to
ff86c62
Compare
Ramza13
requested review from
BrettDong,
Fris0uman,
I-am-Erk,
John-Candlebury,
Maleclypse and
Mom-Bun
as code owners
ZhilkinSerg
force-pushed
the
0.F-dev
branch
2 times, most recently
from
592543e to
54a4e7f
Compare
actual-nh
removed request for
John-Candlebury,
BrettDong,
Fris0uman,
Mom-Bun,
I-am-Erk and
Maleclypse
ZhilkinSerg
force-pushed
the
0.F-dev
branch
3 times, most recently
from
11f8b39 to
a3ed94b
Compare
ZhilkinSerg
force-pushed
the
0.F-dev
branch
3 times, most recently
from
ac1984a to
c8f13cf
Compare
Ramza13
force-pushed
the
bio_memory
branch
4 times, most recently
from
ad77a6b to
89b336e
Compare
actual-nh
added
Bionics
|
Updates for #47253 done? |
meelock
reviewed
Jul 10, 2021
| @@ -1532,4 +1532,4 @@ Gun fault flags: | |||
| - ```CLIMATE_CONTROL``` You are resistant to extreme temperatures. | |||
| - ```HEATSINK``` You are resistant to extreme heat. | |||
| - ```THERMOMETER``` You always know what temperature it is. | |||
|
|
|||
| - ```CBQ_LEARN_BONUS``` You learn CBQ from the bionic bio_cqb faster. | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Unhardcode bio_memory
Describe the solution
Add enchantments/flags for all parts of its effects and use them instead of hardcode. Use enchantments for several traits also having these effects. Remove power usage from preventing skill rust for cleanness of code and because it doesn't make sense that it requires more energy than any of the other usages.
Describe alternatives you've considered
Testing
Additional context