feat: only subscribe to sampled subnets#7860
Closed
twoeths wants to merge 1 commit intopeerDAS_devnet_7from
Closed
feat: only subscribe to sampled subnets#7860twoeths wants to merge 1 commit intopeerDAS_devnet_7from
twoeths wants to merge 1 commit intopeerDAS_devnet_7from
Conversation
This was referenced May 22, 2025
matthewkeil
pushed a commit
that referenced
this pull request
Jul 15, 2025
**Motivation** - this is a precondition for #7860 - when publishing a block, we need to ensure we have enough peers on all column subnets so that we can publish all blobs data to the network - this is not a concern for a node without validator but since this is very easy to achieve, we don't need to care this case **Description** - track `samplingGroups` on PeerData - for sampling groups, ensure at least 6 per subnets - for non-sampling groups, ensure at least 4 per subnets **Metrics on fusaka-devnet-2** we have 25-35 peers on all subnets, so this is more than enough <img width="1537" height="619" alt="Screenshot 2025-07-14 at 11 13 01" src="https://github.com/user-attachments/assets/34c55997-e437-4c53-a829-a9c202a58d1d" /> --------- Co-authored-by: Tuyen Nguyen <twoeths@users.noreply.github.com>
Member
|
@nflaig "we should fix this soonish" |
Contributor
Author
|
closing in favor of #8181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description