Skip to content

Comments

feat: ensure enough peers on all subnets#8057

Merged
matthewkeil merged 4 commits intopeerDASfrom
te/ensure_enough_peers_on_all_subnets
Jul 15, 2025
Merged

feat: ensure enough peers on all subnets#8057
matthewkeil merged 4 commits intopeerDASfrom
te/ensure_enough_peers_on_all_subnets

Conversation

@twoeths
Copy link
Contributor

@twoeths twoeths commented Jul 14, 2025

Motivation

  • this is a precondition for feat: only subscribe to sampled subnets #7860
  • when publishing a block, we need to ensure we have enough peers on all column subnets so that we can publish all blobs data to the network
  • this is not a concern for a node without validator but since this is very easy to achieve, we don't need to care this case

Description

  • track samplingGroups on PeerData
  • for sampling groups, ensure at least 6 per subnets
  • for non-sampling groups, ensure at least 4 per subnets

Metrics on fusaka-devnet-2
we have 25-35 peers on all subnets, so this is more than enough
Screenshot 2025-07-14 at 11 13 01

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.28%. Comparing base (9f30766) to head (3998c0f).
Report is 8 commits behind head on peerDAS.

Additional details and impacted files
@@             Coverage Diff             @@
##           peerDAS    #8057      +/-   ##
===========================================
- Coverage    54.28%   54.28%   -0.01%     
===========================================
  Files          844      844              
  Lines        62555    62672     +117     
  Branches      4702     4733      +31     
===========================================
+ Hits         33961    34019      +58     
- Misses       28520    28579      +59     
  Partials        74       74              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@twoeths
Copy link
Contributor Author

twoeths commented Jul 15, 2025

Screenshot 2025-07-15 at 18 15 01

works fine on fusaka-devnet-2. In fact this PR should not effect anything on devnet because we connect to a lot of super nodes and average peers per data column subnet is so high (25-35)

@twoeths twoeths marked this pull request as ready for review July 15, 2025 11:16
@twoeths twoeths requested a review from a team as a code owner July 15, 2025 11:16
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🚀

@matthewkeil matthewkeil merged commit 223a48c into peerDAS Jul 15, 2025
26 of 29 checks passed
@matthewkeil matthewkeil deleted the te/ensure_enough_peers_on_all_subnets branch July 15, 2025 11:40
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.34.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants