fix: do not always subscribe to all column subnets#7607
fix: do not always subscribe to all column subnets#7607
Conversation
matthewkeil
left a comment
There was a problem hiding this comment.
This is great!!! We were just talking about this actually on the call with the Base contributor. A couple things jump out at me that we may need to consider.
For validator custody the number that we custody/sample will be variable so we should probably use a centralized source of truth for "what count we use." There is an object called the custodyConfig that is built at startup time and that we likely could update as part of the validator custody scope. Could we pass that into the gossip sub and read the value from that instead of recalculating it?
The second is block publishing. We will need to publish all 128 columns when we produce a block so we would need to figure out how to subscribe and unsubscribe during the epoch that we have publish duties.
This is a great idea though!!
to publish it's about to find peers on a topic, not about subscribe to that topic. That's a blocker for this work, will look into that part. |
**Motivation** - we want to have a single CustodyConfig as a preparation for validator custody config work see #7607 (review) - but since we need data on both, I designed to have CustodyConfig created on BeaconChain (main thread) and NetworkCore (network thread) - when we have a change on number of connected validators, need to update both **Description** - on main thread store CustodyConfig on BeaconChain - on network thread, create a wrapped NetworkGlobal to store CustodyConfig and node id there. In the future we can consider storing more data there - add more data to CustodyConfig: sampleGroups, sampledSubnets - use that CustodyConfig everywhere --------- Co-authored-by: Tuyen Nguyen <twoeths@users.noreply.github.com>
|
closing in favor of #7860 |
Motivation
Description