feat: update dataColumnSidecarsByRoot to new spec#7782
Merged
wemeetagain merged 1 commit intoChainSafe:peerDASfrom May 8, 2025
Merged
feat: update dataColumnSidecarsByRoot to new spec#7782wemeetagain merged 1 commit intoChainSafe:peerDASfrom
wemeetagain merged 1 commit intoChainSafe:peerDASfrom
Conversation
Contributor
Author
|
Marking as ready for review, since this is needed for devnet 7 |
wemeetagain
approved these changes
May 8, 2025
matthewkeil
added a commit
that referenced
this pull request
Jun 5, 2025
**Motivation** There is a bug when making byRoot columns requests. The request type was changed to in #7782 and a subtle bug was introduced in how we parse the response.
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The request format for DataColumnSidecarsByRoot was updated to group the columns by blockRoot: ethereum/consensus-specs#4284
Ready for review, but leaving in draft because although it's in the spec for devnet-7, I don't think other clients have merged their PRs yet https://notes.ethereum.org/@ethpandaops/peerdas-devnet-7
Description
{blockRoot: string, column: number}to {blockRoot: string, columns: number[]}` (see spec above for actual ssz types)