fix: columns by root request length#7917
Merged
matthewkeil merged 1 commit intopeerDASfrom Jun 5, 2025
Merged
Conversation
twoeths
approved these changes
Jun 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## peerDAS #7917 +/- ##
========================================
Coverage 54.37% 54.37%
========================================
Files 840 840
Lines 61989 61989
Branches 4653 4654 +1
========================================
Hits 33706 33706
Misses 28215 28215
Partials 68 68 🚀 New features to boost your workflow:
|
Contributor
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
There is a bug when making byRoot columns requests. The request type was changed to in #7782 and a subtle bug was introduced in how we parse the response.