feat: Add initial codegen extension for prelude
#29
Conversation
|
Note that this PR is based on #26 for some of it's testing changes. That is why CI is not currently running. Please do not merge until that PR is merged and this one is rebased on main. |
doug-q
force-pushed
the
doug/init-prelude
branch
from
15682a5
to
2cdac37
Compare
| /// default implementations. | ||
| /// | ||
| /// One should use either [PreludeCodegenExtension::new], or | ||
| /// [CodegenExtsMap::add_prelude_extensions] to work with the |
There was a problem hiding this comment.
So, if for some reason we wanted to tweak code generation for prelude constructs for different targets, we have the flexibility of defining code generation for this new target by implementing the PreludeCodegen trait? That seems very useful if we want to create custom lowering to QIR for other targets that is spec compliant.
| @@ -70,8 +71,7 @@ pub struct TestContext { | |||
|
|
|||
| impl TestContext { | |||
| fn new( | |||
| ext_builder: impl for<'a> Fn(CodegenExtsMap<'a, THugrView>) -> CodegenExtsMap<'a, THugrView> | |||
| + 'static, | |||
| ext_builder: impl for<'a> Fn(&'a Context) -> CodegenExtsMap<'a, THugrView> + 'static, | |||
There was a problem hiding this comment.
Not necessary for me to approve the PR but can you explain the for<'a> notation to me? I haven't seen it, and I can't really tell what it is necessary for the signature.
There was a problem hiding this comment.
This explains it better than I can: https://doc.rust-lang.org/nomicon/hrtb.html
The signature needs to convey that the lifetime of the incoming Context and outgoing CodegenExtsMap are the same, so the liftetime needs a name.
Note that this extension is not intended to be complete, just enough to get started. We include some simplification of test infrastructure, although it is not strictly necessary. An earlier approach required these changes.
doug-q
force-pushed
the
doug/init-prelude
branch
from
f6f028b
to
e8170e6
Compare
## 🤖 New release * `hugr-llvm`: 0.1.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.0](https://github.com/CQCL/hugr-llvm/releases/tag/v0.1.0) - 2024-07-10 ### Bug Fixes - Syntax error - sum type tag elision logic reversed - [**breaking**] Allow Const and FuncDecl as children of Modules, Dataflow Parents, and CFG nodes ([#46](#46)) ### Documentation - fix bad grammar ([#34](#34)) ### New Features - Emission for Call nodes - Support values - add `get_extern_func` ([#28](#28)) - lower CFGs ([#26](#26)) - Add initial codegen extension for `prelude` ([#29](#29)) - [**breaking**] `Namer` optionally appends node index to mangled names. ([#32](#32)) - Implement lowerings for ieq,ilt_s,sub in int codegen extension ([#33](#33)) - Add initial `float` extension ([#31](#31)) - Emit more int comparison operators ([#47](#47)) ### Refactor - clean up fat.rs ([#38](#38)) ### Testing - add a test for sum type tags - Add integration tests lowering guppy programs ([#35](#35)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
Note that this extension is not intended to be complete, just enough to get started.
We include some simplification of test infrastructure, although it is not strictly necessary. An earlier approach required these changes.