This repository was archived by the owner on Mar 5, 2025. It is now read-only.
feat: lower CFGs #26
Merged
feat: lower CFGs #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 83.21% 83.32% +0.11%
==========================================
Files 11 12 +1
Lines 1513 1739 +226
Branches 1513 1739 +226
==========================================
+ Hits 1259 1449 +190
- Misses 168 176 +8
- Partials 86 114 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sorry about the miscellaneous changes in fat.rs, I have more comprehensive changes lined up, this was my attempt at doing as little as reasonable. |
This was referenced Jun 14, 2024
Closed
|
Would be nice if this and #28 get merged soon. I'm slightly blocked on trying to add a lowering for quantum functions using the skeleton code from the draft PR for defining quantum ops until these are merged. |
mark-koch
reviewed
Jun 18, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
## 🤖 New release * `hugr-llvm`: 0.1.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.0](https://github.com/CQCL/hugr-llvm/releases/tag/v0.1.0) - 2024-07-10 ### Bug Fixes - Syntax error - sum type tag elision logic reversed - [**breaking**] Allow Const and FuncDecl as children of Modules, Dataflow Parents, and CFG nodes ([#46](#46)) ### Documentation - fix bad grammar ([#34](#34)) ### New Features - Emission for Call nodes - Support values - add `get_extern_func` ([#28](#28)) - lower CFGs ([#26](#26)) - Add initial codegen extension for `prelude` ([#29](#29)) - [**breaking**] `Namer` optionally appends node index to mangled names. ([#32](#32)) - Implement lowerings for ieq,ilt_s,sub in int codegen extension ([#33](#33)) - Add initial `float` extension ([#31](#31)) - Emit more int comparison operators ([#47](#47)) ### Refactor - clean up fat.rs ([#38](#38)) ### Testing - add a test for sum type tags - Add integration tests lowering guppy programs ([#35](#35)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.