Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows and cookiecutter hook #123

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Sep 11, 2024

wait until

  1. add workflow managing release-scripts#18
  2. matrix tests yml
  3. further tests on pdfgui and pdffit2

Copy link
Collaborator

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks so much!. It has a conflict that needs fixing, but sincel you are fixing that, can we also fix the one inline comment and I can merge. We may want to test the instructions by having someone who is not @Tieqiong, e.g., @bobleesj and then @sbillinge to follow the instructions on one repo and polish everything. Then we can use that version in production (for all the repos....)

README.md Outdated
8. Copy the code from the old repo to the cookiecutter repo, without overwriting files in the destination (i.e., use `cp -n` or `cp --no-clobber`. e.g., from the cookiecutter directory where you currently are, type `cp -n -r ../src .` if the old code is already in a directory `src`. If there is no src directory, it will be something like `cp -n -r ../diffpy ./src`.
9. From the cookiecutter directory type `git status`. You will see a list of files that have been modified, deleted or are untracked. Untracked files are in the cookiecutter but not in the original repo, deleted files are in the original but haven't been moved over, and modified files are in both but have been changed.
10. Let's now copy over any documentation, similar to what we did with the src files. We want to copy over everything in the `doc/<path>/source` file from the old repo to the `doc/source` file in the new repo. In some old pacakges, `<path>` will be something like `manual` and in others it will just not exist.
8. Look into `.github/workflows`, change `c_extension` and `headless` parameters to `true` if the package has C extensions or is a gui package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lead this with the target situtuation, so somethin glike "If the package has C extensions....." which will mean I only have to read the first few words and not the whole thing if I don't have c....

@bobleesj
Copy link
Contributor

@Tieqiong I can be your test buddy

@sbillinge
Copy link
Collaborator

@Tieqiong this seems to have conflicts. I am ok merging this but it will breaK everything until we get all the parts merged. Do you have a suggestion for the best way to do this? Maybe we should merge into a separate branch, get those working together, and then merge into main? Or if you have it thoroughly tested we can just merge into main, but don all the pieces at once?

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Sep 12, 2024

@Tieqiong this seems to have conflicts. I am ok merging this but it will breaK everything until we get all the parts merged. Do you have a suggestion for the best way to do this? Maybe we should merge into a separate branch, get those working together, and then merge into main? Or if you have it thoroughly tested we can just merge into main, but don all the pieces at once?

yes let's do that, into a separate branch

@sbillinge
Copy link
Collaborator

I made a branch called central_park to park this for now. I can't quite see how to edit the PR to change it on my phone. Please could you do that? Sorry about that.

@sbillinge sbillinge changed the base branch from main to central_park September 12, 2024 13:39
@sbillinge sbillinge merged commit d3ead13 into Billingegroup:central_park Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants