Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workflow managing #18

Merged
merged 1 commit into from
Sep 11, 2024
Merged

add workflow managing #18

merged 1 commit into from
Sep 11, 2024

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Sep 11, 2024 •
edited
Loading

still need to add matrix test, waiting for diffpy/diffpy.pdfgui#205

Then do a test on pdfgui and pdffit2 after merge

@Tieqiong Tieqiong mentioned this pull request Sep 11, 2024
Merged
@bobleesj bobleesj mentioned this pull request Sep 11, 2024
Closed
sbillinge
sbillinge reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a meaningful way of reviewing this so I suggest I just merge it and we can test. Does that make sense @Tieqiong ?

@Tieqiong
Copy link
Contributor Author

Yes please. Thanks

@sbillinge sbillinge merged commit 8a87065 into Billingegroup:main Sep 11, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillinge sbillinge sbillinge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tieqiong @sbillinge