Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change on push workflow to be a matrix over all supported python versions #109

Closed
sbillinge opened this issue Aug 22, 2024 · 6 comments
Closed
Milestone

Comments

@sbillinge
Copy link
Collaborator

Only do this on push to main for pure python packages.

@bobleesj
Copy link
Contributor

@Tieqiong Since it's a part of the milestone, will be this implemented after

#123

?

@Tieqiong
Copy link
Contributor

A matrix test workflow is mostly ok, but could be tricky for small things, even for pure python packages.

For example, for Mac platform there's no up to date, usable version of pdffit2 on conda forge, which means for a matrix test we need to specifically ask macOS to uninstall diffpy.pdffit2 (if installed), install gsl, then pip install pdffit2 (see diffpy/diffpy.pdfgui#205).

I can try to write one, but further fixing is going to be needed for sure.

@bobleesj
Copy link
Contributor

Okay, since our current priority is testing the central CI system (#115), let's re-visit this as soon as we are done with it.

@sbillinge
Copy link
Collaborator Author

We can just have the matrix so what doesn't break to begin with. Let's discuss.

@bobleesj
Copy link
Contributor

bobleesj commented Oct 2, 2024

Can be closed with the new PR Billingegroup/release-scripts#51

@bobleesj
Copy link
Contributor

@sbillinge Could you please close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants