-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change on push workflow to be a matrix over all supported python versions #109
Comments
A matrix test workflow is mostly ok, but could be tricky for small things, even for pure python packages. For example, for Mac platform there's no up to date, usable version of pdffit2 on conda forge, which means for a matrix test we need to specifically ask macOS to uninstall diffpy.pdffit2 (if installed), install gsl, then pip install pdffit2 (see diffpy/diffpy.pdfgui#205). I can try to write one, but further fixing is going to be needed for sure. |
Okay, since our current priority is testing the central CI system (#115), let's re-visit this as soon as we are done with it. |
We can just have the matrix so what doesn't break to begin with. Let's discuss. |
Can be closed with the new PR Billingegroup/release-scripts#51 |
@sbillinge Could you please close this issue? |
Only do this on push to main for pure python packages.
The text was updated successfully, but these errors were encountered: