Skip to content

fix(types): allow proxyFactory to return null or undefined #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Vincentdevreede
Copy link
Contributor

@Vincentdevreede Vincentdevreede commented May 12, 2025

Follow-up to #96 allow custom proxyFactory to use non-default proxyTypes
This updates the proxyFactory type to allow returning null or undefined.

Apologies for missing this in the previous PR!

Preview of the error:
image

@Vincentdevreede Vincentdevreede marked this pull request as draft May 12, 2025 12:49
@Vincentdevreede Vincentdevreede marked this pull request as ready for review May 12, 2025 12:59
@jkyberneees jkyberneees requested a review from Copilot May 14, 2025 19:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Collaborator

@jkyberneees jkyberneees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkyberneees jkyberneees merged commit 165fe06 into BackendStack21:master May 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants