Skip to content

fix(types): allow proxyFactory to return null or undefined #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

fix(types): allow proxyFactory to return null or undefined #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
647ff41
fix(types): allow proxyFactory to return null or undefined
Vincentdevreede May 12, 2025
76d36cc
fix(types): improve formatting of proxyFactory type definition
Vincentdevreede May 12, 2025
e56ae13
fix(types): update Type and ProxyFactoryOpts for improved type safety
Vincentdevreede May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as restana from 'restana'

declare namespace fastgateway {
type Type = 'http' | 'lambda'
type Type = 'http' | 'lambda' | (string & {})

type Method =
| 'GET'
Expand All @@ -20,7 +20,7 @@ declare namespace fastgateway {
}

interface ProxyFactoryOpts {
proxyType: string
proxyType: Type
opts: {}
route: Route
}
Expand Down Expand Up @@ -70,7 +70,7 @@ declare namespace fastgateway {

interface Options<P extends restana.Protocol> {
server?: Object | restana.Service<P> | Express.Application
proxyFactory?: (opts: ProxyFactoryOpts) => Function
proxyFactory?: (opts: ProxyFactoryOpts) => Function | null | undefined
restana?: {}
middlewares?: Function[]
pathRegex?: string
Expand Down