fix(gateway): allow custom proxyFactory to use non-default proxyTypes#96
Merged
jkyberneees merged 4 commits intoBackendStack21:masterfrom May 10, 2025
Conversation
- Skip proxyType validation when a custom proxyFactory is provided - Fallback to defaultProxyFactory only if custom one returns undefined - Default missing proxy hooks to NOOP functions
jkyberneees
requested changes
May 8, 2025
Collaborator
jkyberneees
left a comment
There was a problem hiding this comment.
Hi @Vincentdevreede many thanks for supporting the library evolution. I definitively like the proposal and makes total sense.
Could you please fix linting issues and extend the docs to reflect your proposal? Afterwards I will proceed with merging it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves flexibility in the gateway by allowing custom proxyFactory implementations to define and use custom proxyType values without triggering an "Unsupported proxy type" error.
Changes
Previously, providing a custom proxyFactory and proxyType would still result in an error unless the type was listed in the internal PROXY_TYPES list. This fix ensures full control when extending proxy behavior through configuration.