Sync dependency removal branch with latest dev branch #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ityParameters.java Co-authored-by: Avery-Dunn <62066438+Avery-Dunn@users.noreply.github.com>
Token revocation for service fabric
Correct IMDS resource ID query parameter
…ityTestConstants.java Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Support multiple date formats in managed identity flows
…ityTestConstants.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java
Refactor Managed Identity unit tests
Add versioning and support doc
Version updates for 1.21.0
Suppressed SHA-1 CodeQL flag
Add OIDC issuer validation and new testing style
…th2-oidc-sdk Bump com.nimbusds.oauth2-oidc-sdk from 11.23 to 11.23.1
Version updates for 1.22.0
Add/improve javadocs for interface classes
# Conflicts: # README.md # changelog.txt # msal4j-sdk/README.md # msal4j-sdk/bnd.bnd # msal4j-sdk/pom.xml # msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/HttpHelper.java # msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ManagedIdentityRequest.java # msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/StringHelper.java # msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/TokenRequestExecutor.java # msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/CacheFormatTests.java # msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ClientCertificateTest.java # msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java # msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/TokenRequestExecutorTest.java
neha-bhargava
approved these changes
Aug 7, 2025
Contributor
neha-bhargava
left a comment
neha-bhargava
left a comment
There was a problem hiding this comment.
High level looks good. I just have a question on the removed dependencies in pom
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> |
Contributor
There was a problem hiding this comment.
Why is this dependency removed?
Contributor
Author
There was a problem hiding this comment.
This dependency was removed in the main branch back in June: #962
Back then I noticed this dependency and some others weren't actually used anywhere in the library, all of the references to it must've been removed by various changes over the years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to get the dependency removal feature branch back in sync with dev in preparation for the upcoming release.
Almost all of the changes here were already approved in previous PRs, with the exception of two commits:
-Big commit handling most of the merge conflicts: 956bcb1
-Small commit resolving some final post-merge issues: dfae289
The beta branch was months behind dev so the list of changes is large, however the actual changes in the above two commits just resolved merge conflicts and the actual behavior of the library should not have changed.