Conversation
Avery-Dunn
commented
Jun 5, 2025
Avery-Dunn
commented
- Add support for claims and client capabilities in Managed Identity scenarios (Add APIs to add client capabilities and claims #929, Token revocation for service fabric #943)
- Improve retry logic for HTTP requests, and add API to disable retries (Refactor retry logic and add special behavior for IMDS #960, Add API to disable internal retry behavior #963, Consistently use constants for HTTP status codes #964)
- Support multiple date formats in Managed identity scenarios (Support multiple date formats in managed identity flows #956)
- Fix query parameter issue in IMDS scenarios (Correct IMDS resource ID query parameter #954)
- Update dependencies used in tests to avoid CVE warnings (Update dependencies and improve formatting of pom.xml #962)
changelog.txt
Outdated
| @@ -1,3 +1,11 @@ | |||
| Version 1.21.0 | |||
| ============= | |||
| - Add support for claims and client capabilities in Managed Identity scenarios (#929, #943) | |||
There was a problem hiding this comment.
The new public claims/capabilities APIs were added in #929 and already released, and #943 added the actual behavior behind those APIs just in Service Fabric
Maybe the changelog should say "Add support for claims and client capabilities in Service Fabric scenarios" to be more clear? Because if it isn't actually ready for release that should've been mentioned in the PRs
| Version 1.21.0 | ||
| ============= | ||
| - Add support for claims and client capabilities in Managed Identity scenarios (#929, #943) | ||
| - Improve retry logic for HTTP requests, and add API to disable retries (#960, #963, #964) |
There was a problem hiding this comment.
Please inform Vinay about this new API, otherwise it's going to be a breaking change for them if they don't use the API.
There was a problem hiding this comment.
Are you saying that having IMDS scenarios retry on a couple of different status codes from normal managed identity is considered a breaking change? If so, why would it only be a problem for Azure SDK?
Other than the status codes for IMDS it was just a refactor of the existing retry behavior, and a new API to disable that behavior
changelog.txt
Outdated
| @@ -1,3 +1,11 @@ | |||
| Version 1.21.0 | |||
| ============= | |||
| - Add support for claims and client capabilities in Service Fabric scenarios (#929, #943) | |||
There was a problem hiding this comment.
Maybe mention "token revocation" in some way?
There was a problem hiding this comment.
Just changed it to "Add support for claims, client capabilities, and token revocation in Service Fabric scenarios"
3 participants
