Consistently use constants for HTTP status codes#964
Merged
Avery-Dunn merged 1 commit intoavdunn/retry-behaviorfrom Jun 4, 2025
Merged
Consistently use constants for HTTP status codes#964Avery-Dunn merged 1 commit intoavdunn/retry-behaviorfrom
Avery-Dunn merged 1 commit intoavdunn/retry-behaviorfrom
Conversation
Robbie-Microsoft
approved these changes
Jun 4, 2025
This was referenced Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #960 made it clear that the library is inconsistent when it comes to HTTP status codes: not all codes had a constant, and even when there was a constant it often wasn't used.
This PR adjusts the
HttpStatusenum introduced in #960 to be a simpler class of constants and helper methods, and refactors every status code reference to use these constants.This is a separate PR in order to be much easier to review, each individual change is minor and they should not affect any existing behavior.
The status code constants follow the style in HttpURLConnection, a standard Java package that also has these sorts of constants: https://docs.oracle.com/javase/8/docs/api/java/net/HttpURLConnection.html
However, I didn't want to rely on that since we only need a small subset and none of the other code, plus this allows us to add custom helper methods (like the isServerError() that checks for 5xx errors)