[formrecognizer] initial selection marks #14024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fr-selection-marks * 'master' of https://github.com/Azure/azure-sdk-for-python: [form recognizer] Add selection forms (#14511) Update Azure.Identity and KeyVault codeowners (#14470) Minimize packages installed for depends test (#13957) Change name to <entity>_name naming for remaining "name" parameters in AdministrationClient to normalize with existing naming schemes. (#14393)
iscai-msft
requested review from
danieljurek,
iscai-msft and
rakshith91
as code owners
maririos
reviewed
Oct 15, 2020
sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py
Show resolved
Hide resolved
maririos
reviewed
Oct 15, 2020
sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py
Show resolved
Hide resolved
maririos
reviewed
Oct 15, 2020
| @@ -408,6 +415,13 @@ def assertFormPagesHasValues(self, pages): | |||
| self.assertBoundingBoxHasPoints(cell.bounding_box) | |||
| self.assertFieldElementsHasValues(cell.field_elements, page.page_number) | |||
|
|
|||
| if page.selection_marks: | |||
| for selection_mark in page.selection_marks: | |||
There was a problem hiding this comment.
If we leave Text empty, should we check here that no one assigned a value to it?
maririos
previously approved these changes
Oct 15, 2020
maririos
approved these changes
Oct 16, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Oct 20, 2020
…into add_business_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits) samples updates from other branch (Azure#14598) [form recognizer] add multipage business card form (Azure#14613) Remove extra newline at the end of the file (Azure#14608) Update .gitignore (Azure#14609) Enable the link check for link verification step. (Azure#14604) Switch the content from array to string. (Azure#14576) [Fileshare] Added support for set share properties including access tier (Azure#14355) [EventHubs & ServiceBus] add python3.9 support (Azure#14301) Add parse_key_vault_certificate_id method and tests (Azure#14518) Enable Codespaces. (Azure#14564) Failed the anchor links with Uppercase. (Azure#14535) Sync eng/common directory with azure-sdk-tools for PR 1091 (Azure#14550) Only check the touched markdown files in PR for the Verify link step (Azure#14466) [formrecognizer] add logic to set page_number on `ContactNames` field (Azure#14552) update deps for multiapi (Azure#14534) add sample tests for business cards and model compose (Azure#14515) Ma accept str for datetime (Azure#14517) Fix anchor links so they work when converting to html [formrecognizer] initial selection marks (Azure#14024) Mypy Compatibilty for EventGrid (Azure#14344) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
live test run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=577105&view=results. spoiler: it passed