Skip to content

[ServiceBus] Change name to <entity>_name naming for remaining "name" parameters #14393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KieranBrantnerMagee
Copy link
Member

For AdministrationClient to normalize with existing naming schemes.

…n AdministrationClient to normalize with existing naming schemes.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Oct 9, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] November milestone Oct 9, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Oct 9, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. changelog update is missing :P

@KieranBrantnerMagee
Copy link
Member Author

re: changelog update, since this is all green and we're tight for time, I slipped that line here. Not my proudest moment but if you have no issues I'll slip this in.

@KieranBrantnerMagee KieranBrantnerMagee merged commit 28a99a0 into Azure:master Oct 14, 2020
iscai-msft added a commit that referenced this pull request Oct 14, 2020
…into fr-selection-marks

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [form recognizer] Add selection forms (#14511)
  Update Azure.Identity and KeyVault codeowners (#14470)
  Minimize packages installed for depends test (#13957)
  Change name to <entity>_name naming for remaining "name" parameters in AdministrationClient to normalize with existing naming schemes. (#14393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ServiceBus] Normalize ServiceBusAdministrationClient name parameter naming.
2 participants