Only check the touched markdown files in PR for the Verify link step #14466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
This was referenced Oct 13, 2020
Merged
Merged
mitchdenny
reviewed
Oct 14, 2020
| @@ -77,7 +77,8 @@ jobs: | |||
| steps: | |||
| - template: ../../../common/pipelines/templates/steps/verify-links.yml | |||
| parameters: | |||
| Directory: "sdk/${{ parameters.ServiceDirectory }}" | |||
| Directory: '' | |||
| Urls: (git diff origin/master HEAD --name-only -- *.md) | |||
There was a problem hiding this comment.
This seems to be a strange value to be input into a parameter called Urls.
There was a problem hiding this comment.
Urls can also point to local file paths :)
This was referenced Oct 15, 2020
Closed
Closed
Closed
weshaggard
previously approved these changes
Oct 15, 2020
weshaggard
approved these changes
Oct 16, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Oct 20, 2020
…into add_business_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits) samples updates from other branch (Azure#14598) [form recognizer] add multipage business card form (Azure#14613) Remove extra newline at the end of the file (Azure#14608) Update .gitignore (Azure#14609) Enable the link check for link verification step. (Azure#14604) Switch the content from array to string. (Azure#14576) [Fileshare] Added support for set share properties including access tier (Azure#14355) [EventHubs & ServiceBus] add python3.9 support (Azure#14301) Add parse_key_vault_certificate_id method and tests (Azure#14518) Enable Codespaces. (Azure#14564) Failed the anchor links with Uppercase. (Azure#14535) Sync eng/common directory with azure-sdk-tools for PR 1091 (Azure#14550) Only check the touched markdown files in PR for the Verify link step (Azure#14466) [formrecognizer] add logic to set page_number on `ContactNames` field (Azure#14552) update deps for multiapi (Azure#14534) add sample tests for business cards and model compose (Azure#14515) Ma accept str for datetime (Azure#14517) Fix anchor links so they work when converting to html [formrecognizer] initial selection marks (Azure#14024) Mypy Compatibilty for EventGrid (Azure#14344) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested: https://dev.azure.com/azure-sdk/public/_build/results?buildId=572777&view=logs&j=b267a483-7571-5116-57ef-b701bc1e1bd9
Java: Azure/azure-sdk-for-java#16008
.NET: Azure/azure-sdk-for-net#15929
Python: #14466
JS: Azure/azure-sdk-for-js#11803
Android: Azure/azure-sdk-for-android#405
C: Azure/azure-sdk-for-c#1431
CPP: Azure/azure-sdk-for-cpp#787
Go: Azure/azure-sdk-for-go#12809
IOS: Azure/azure-sdk-for-ios#488