[text analytics] return None for offset and length for v3.0 #13382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maririos
reviewed
Aug 27, 2020
| if isinstance(entity, _v3_0_models.Entity): | ||
| # we do not return offset and length for v3.0 since | ||
| # the correct encoding was not introduced for v3.0 | ||
| offset = None |
There was a problem hiding this comment.
is this the pattern other libraries have taken? I am new to this paradigm as in TA and FR we can only support one version of the SDK
There was a problem hiding this comment.
for python, we're supposed to support all API versions, the user only needs to pass in the api_version as a kwarg if they don't want the default.
| self.assertIsNone(entities[0].matches[0].offset) | ||
| self.assertIsNone(entities[0].matches[0].length) | ||
| self.assertIsNone(entities[0].matches[0].offset) | ||
| self.assertIsNone(entities[0].matches[0].length) |
There was a problem hiding this comment.
the indices are all the same here (and in the async test)
…into return_none_for_offset_length_v3 * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] add string-index-type support (Azure#13378) [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383) Send spec (Azure#13143) Anomaly Detector 3.0.0b2 release (Azure#13351) azure-keyvault-administration generated code (Azure#12098) fixed bug in querying by page using continuation token (Azure#13298)
maririos
approved these changes
Aug 28, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Sep 1, 2020
…into expose_parse_vault_id * 'master' of https://github.com/Azure/azure-sdk-for-python: (37 commits) [text analytics] add versionadded sphinx documentation (Azure#13450) [text analytics] add bing_id property to LinkedEntity class (Azure#13446) fix typing for paging methods (Azure#13410) [text analytics] add domain_filter param (Azure#13451) fix issue Azure#11658 for is_valid_resource_id (Azure#11709) added create_table_if_not_exists method to table service client (Azure#13385) [ServiceBus] Test and failure improvements (Azure#13345) Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275) Switch retry (Azure#13264) [ServiceBus] ServiceBusClient close spawned children (Azure#13077) fixing version issue by not overwriting the version with the semantic… (Azure#13411) clean up reference and tests (Azure#13412) Consistent returns (Azure#13245) [text analytics] return None for offset and length for v3.0 (Azure#13382) edit all authentication files and add a test (Azure#13355) Add managed_identity_client_id argument to DefaultAzureCredential (Azure#13218) [text analytics] add string-index-type support (Azure#13378) [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383) Send spec (Azure#13143) Anomaly Detector 3.0.0b2 release (Azure#13351) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13365