Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-keyvault-administration scaffold #12098

Merged
merged 5 commits into from
Aug 27, 2020
Merged

Conversation

chlowell
Copy link
Member

This package will handle Key Vault's RBAC and full vault backup/restore features. This PR adds packaging boilerplate, generated code for the new features, and common azure-keyvault-* code.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 17, 2020
@chlowell chlowell force-pushed the administration branch 2 times, most recently from cff5d5d to 299279f Compare June 24, 2020 15:11
@chlowell chlowell requested a review from iscai-msft June 24, 2020 15:43
@chlowell chlowell marked this pull request as ready for review June 24, 2020 15:43
@chlowell chlowell requested a review from schaabs as a code owner June 24, 2020 15:43
iscai-msft
iscai-msft previously approved these changes Jun 24, 2020
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some comments, but feel free to implement at a later date / ignore

self._client = client
return

api_version = kwargs.pop("api_version", None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this package is currently just 7.2-preview, should we not include checking api_version as a kwarg and calling load_generated_api from the multi_api file?

My thinking is that for now we just only load the 7.2-preview code, and by the time there is a new service api version for administration, we can generate the code with the flag --multiapi and autorest will generate a multiapi client for us, and then we can pass in api_version directly to the generated multiapi client


# generated clients don't use their credentials parameter
self._client = generated.client_cls(credentials="", pipeline=pipeline)
self._models = generated.models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: I think we can just import v7.2-preview models for now

# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.
# ------------------------------------
from collections import namedtuple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you decide to remove the multi api code from the client base, we can get rid of this file too

@chlowell chlowell marked this pull request as draft July 31, 2020 16:20
@chlowell
Copy link
Member Author

Updated with a generated multiapi client (thanks @iscai-msft).

@chlowell chlowell marked this pull request as ready for review August 12, 2020 19:18
iscai-msft
iscai-msft previously approved these changes Aug 13, 2020
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay looks great

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chlowell chlowell merged commit a5e4473 into Azure:master Aug 27, 2020
@chlowell chlowell deleted the administration branch August 27, 2020 16:30
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 28, 2020
…into return_none_for_offset_length_v3

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [text analytics] add string-index-type support (Azure#13378)
  [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383)
  Send spec (Azure#13143)
  Anomaly Detector 3.0.0b2 release (Azure#13351)
  azure-keyvault-administration generated code (Azure#12098)
  fixed bug in querying by page using continuation token (Azure#13298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants